Skip to content

Fixes #1717 by skiping the %% literal in parse_conversion_specifiers. #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixes #1717 by skiping the %% literal in parse_conversion_specifiers. #1905

wants to merge 2 commits into from

Conversation

fabianhjr
Copy link
Contributor

@fabianhjr fabianhjr commented Jul 19, 2016 •
edited
Loading

I think this should be clearer than doing regex changes; passes all tests and ignores %% correctly.

Fixes #1717

@fabianhjr fabianhjr mentioned this pull request Jul 19, 2016
Closed
@ddfisher
Copy link
Collaborator

Thanks for taking a swing at this! I'm going to go with #1908 (see #1900 for my reasoning).

@ddfisher ddfisher closed this Jul 19, 2016
@fabianhjr fabianhjr deleted the fix-1717 branch July 20, 2016 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianhjr @ddfisher