-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix #1855: Multiassign from Union (take 2) #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
c53a1c4
NewType+namedtuple: common method for typeinfo
elazarg 7e043d0
handle union, add test
elazarg 9a50d73
kill blank
elazarg 5c4d86e
more tests
elazarg 60cfbbb
handle binding
elazarg 5e9e0f2
try to minimize visual difference
elazarg 71f8475
(cont.)
elazarg 42b6e73
add tests
elazarg 0560bd8
no binder yet
elazarg da3a516
Support rebinding on multiassignment from union
elazarg ab60317
Merge remote-tracking branch 'upstream/master' into multiassign_union
elazarg 6bb5519
more tests
elazarg 3b4cd13
Merge remote-tracking branch 'upstream/master'
elazarg 38651c4
handle union, add test
elazarg 9000099
kill blank
elazarg f20f3d6
more tests
elazarg 61be4e9
handle binding
elazarg 9830cb4
try to minimize visual difference
elazarg 59dc8b7
(cont.)
elazarg 7f304e4
add tests
elazarg ff1ca80
no binder yet
elazarg 168087e
Support rebinding on multiassignment from union
elazarg 3f198cf
more tests
elazarg 4fa059f
Rebase
elazarg ab35a4c
Merge
elazarg 00f34ce
small merge fix
elazarg 0cccb4b
Merge
elazarg a3ef3d5
what typeshed?
elazarg 60c032f
Merge remote-tracking branch 'upstream/master' into multiassign_union2
elazarg 21ac123
Merge remote-tracking branch 'upstream/master' into multiassign_union2
elazarg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing new in this function. It's only extracted, and the comment is slightly more elaborated.