Allow importing a submodule ahead of its parent module #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 10, 2016 12:41
Fixes #2133. This is the third fix for this issue. I think I've finally nailed it. The solution is not to bail out early when the parent module is unavailable -- if all the imports are submodules of a package that's acceptable (the bug was that in incremental mode it's possible that the parent is fresh and has not been entered into the modules dict yet, but the bail-out caused the import to be marked as missing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2133.
(This is the third fix for this issue. I'm happiest with this version.)
The solution is not to bail out early when the parent module is
unavailable -- if all the imports are submodules of a package that's
acceptable (the bug was that in incremental mode it's possible that
the parent is fresh and has not been entered into the modules dict
yet, but the bail-out caused the import to be marked as missing).