Allow covariant args in constructor #2888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Feb 21, 2017
test-data/unit/check-classes.test
Outdated
|
|
||
| class C(Generic[T_co]): | ||
| def __init__(self, x: T_co) -> None: # This should be allowed | ||
| pass |
There was a problem hiding this comment.
Also try assignment self.x = x in __init__ and reveal_type(self.x) in a method other than __init__.
There was a problem hiding this comment.
Fixed in a new commit.
|
Looks good now -- thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2850
It looks like we could make a simple exclusion for
__init__and__new__.