Fix #2308: Keep suppressed imports in the suppressed list #3065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here was a logic discrepancy.
In one side of the code, suppressed modules need to be inside
manager.modules_missing
in order to stay suppressed. In the other side of the code, suppressed modules are never checked, meaning they are never added to that run'smodules_missing
.There's a 99% chance this fix is mostly wrong, because the incremental code is really freaking complicated, but at least I get an A for effort, right? ;)