Skip to content

Fix last character cut in html-report if file does not end with newline #3466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2017
Merged

Fix last character cut in html-report if file does not end with newline #3466

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b70762
Fix last character cut in html-report if file does not end with newline
ilinum May 26, 2017
03cf727
Use strip() instead of checking the last character
ilinum May 26, 2017
9048c98
Use rstrip() instead of strip()
ilinum May 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def on_file(self,
etree.SubElement(root, 'line',
number=str(lineno),
precision=stats.precision_names[status],
content=line_text[:-1])
content=line_text.rstrip('\n'))
# Assumes a layout similar to what XmlReporter uses.
xslt_path = os.path.relpath('mypy-html.xslt', path)
transform_pi = etree.ProcessingInstruction('xml-stylesheet',
Expand Down