[WIP] When a module has errors but the interface hash is the same, keep the cache #4353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cache Closes python#4212. However, there are still many scenarios where a trivial error affects the interface hash and hence causes a recheck of everything downstream. Also, this affects regular incremental mode too (making it faster, but if there's a bug in my logic, it will also be hit by that bug.)
|
Looking at the test failures:
|
|
No, the "different idea" may fix the last failing test but it doesn't consistently address the underlying problem. Tomorrow... |
|
Well, this is really tricky. I think I may have to reconsider a lot more of the way dependencies and cache freshness are tracked... |
gvanrossum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4212.
However, there are still many scenarios where a trivial error affects
the interface hash and hence causes a recheck of everything
downstream.
Also, this affects regular incremental mode too (making it faster, but
if there's a bug in my logic, it will also be hit by that bug.)