Skip to content

Add dmypy.json to .gitignore #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2018
Merged

Add dmypy.json to .gitignore #4401

merged 1 commit into from
Jan 4, 2018

Conversation

msullivan
Copy link
Collaborator

No description provided.

@msullivan msullivan requested a review from JukkaL December 21, 2017 20:01
gvanrossum
gvanrossum approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but it should be deleted when you stop the daemon, so it's presence signals an irregularity. Up to you.

@msullivan
Copy link
Collaborator Author

The normal case for using the daemon will be that it will be running all the time, though, including while doing git operations. So I think it is worth cleaning that up.

@msullivan msullivan merged commit d8892c4 into master Jan 4, 2018
@msullivan msullivan deleted the ignore_dmypy branch January 4, 2018 20:59
@JelleZijlstra JelleZijlstra mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@JukkaL JukkaL Awaiting requested review from JukkaL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msullivan @gvanrossum