Various improvements to fine-grained incremental checking #4423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the changes are about supporting command-line options in fine-grained incremental test cases.
Most of the changes just enable testing skipped imports.
|
Is it okay if I leave review of this to @msullivan ? |
msullivan
reviewed
Jan 3, 2018
mypy/test/testfinegrained.py
Outdated
| These are defined through a comment like '# cmd: main a.py' in the test case | ||
| description. | ||
| """ | ||
| # TODO: Support defining sepately for each incremental step. |
msullivan
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of major changes:
--ignore-missing-imports.super().[This is the first batch of my unmerged changes. I have around 2 additional batches waiting for this to be merged. I think that it's more efficient to review in batches instead of creating a large number of smaller PRs for now, but once things stabilize a bit I'll start creating smaller PRs.]