Skip to content

fine-grained: strip is_abstract #4820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2018
Merged

fine-grained: strip is_abstract #4820

merged 1 commit into from
Mar 29, 2018

Conversation

msullivan
Copy link
Collaborator

Fixes a crash bug

@msullivan msullivan requested review from JukkaL and ilevkivskyi March 28, 2018 23:47
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

This gives me two ideas:

  • From time to time we can run fine grained tests while randomizing order of targets reprocessing and running every test few dozen times. I have been bitten few times by this, and it was quite painful. And I bet if we will do this now, then we could discover few another similar bugs.
  • We can order target modules not by name (which is quite arbitrary) but by topological sort (plus some heuristics within cycles similar to what we currently have to order modules within SCCs in normal incremental). I already proposed this from the point of view of performance, but now it looks like stability/predictability may be a more important argument.

@msullivan
Copy link
Collaborator Author

I actually just hacked something up to do a fairly basic randomization (just randomizing the order of files passed in), and after accounting for differing error message order and one test that has two possible files that can block it, I haven't been able to get a failure out of it, which I find pleasantly surprising.

Possibly randomizing the order of target reprocessing might cause more grief

@msullivan msullivan merged commit 0f8385b into master Mar 29, 2018
@msullivan msullivan deleted the abstract-strip branch March 29, 2018 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants