Move test_stubs and test_samples to pytest #5142
Conversation
|
Hm, we will have to be careful with this and #5051. I think it should be fine for me to rebase my PR on this. |
| run_mypy(mypy_args + [f]) | ||
|
|
||
|
|
||
| def find_files(base: str, prefix: str = '', suffix: str = '') -> List[str]: |
There was a problem hiding this comment.
Perhaps these should be moved to mypy.test.helpers since they are used outside of this file?
There was a problem hiding this comment.
I don't think so. It's a temporary hack in runtests.py, and should be moved here soon.
There was a problem hiding this comment.
Ah, that is true. I think this okay then.
|
Any reason not to merge this now? |
I haven't had the time to review it. If you trust Ethan and/or you've reviewed (and preferably tested) it yourself, go right ahead! |
|
@elazarg It seems there is a merge conflict. When you fix the merge conflict please also delete 3.3 from the list of tested typeshed directories. |
|
@ethanhs done (I've also removed 3.4) |
| modules = [] | ||
| # TODO: This should also test Python 2, and pass pyversion accordingly. | ||
| for version in ["2and3", "3", "3.5"]: | ||
| # FIX: remove 'builtins', this directory does not exist |
There was a problem hiding this comment.
What does "FIX:" mean? Is it a TODO? Why not do it now?
There was a problem hiding this comment.
I guess you are right. I think I didn't want to change anything
Using the api, similarly to #5087.
stdlibsamplesis not included in this PR since it requires special handling of working directory and paths.This is another item for #1673.