Visit resolved forward refs by third pass type visitor #5433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Aug 8, 2018
| # otherwise the type checker may crash as it expects | ||
| # things to be right. | ||
| t.args = [AnyType(TypeOfAny.from_error) for _ in t.type.type_vars] | ||
| t.invalid = True |
There was a problem hiding this comment.
Did anything change here, or is it a pure refactor?
There was a problem hiding this comment.
This is a pure refactor. I first tried a different solution, that required calling this manually from other module, but then found a simpler solution. However, looking at it, it seemed to me it actually looks better as a separate function (all visitor methods look compact this way).
There was a problem hiding this comment.
Agreed, just wanted to check I wasn't missing anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4649
This also fixes similar cases of crashes with extreme forward referencing. The idea is quite straightforward, previously forward references just resolved during third pass were not accepted by the third pass visitor itself, this is now fixed.