Avoid infinite recursion in type queries #5434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Aug 8, 2018
| @@ -1915,6 +1915,7 @@ class TypeQuery(SyntheticTypeVisitor[T]): | |||
|
|
|||
| def __init__(self, strategy: Callable[[Iterable[T]], T]) -> None: | |||
| self.strategy = strategy | |||
| self.seen = [] # type: List[Type] | |||
There was a problem hiding this comment.
How big do we expect seen to get? If we think it will get pretty big we could make it a set of ids of Typess
There was a problem hiding this comment.
My expectation is that seen should be never larger than few dozens of types. I think we discussed this with @JukkaL when implementing ForwardReferenceResolver that uses the same pattern and decided it is "small" (whatever it means).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5357
Fixes #4780
This might potentially fix similar crashes on recursive types.