Eliminate some conditional method defs in fastparse #5499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like they might not be necessary anymore, and mypyc doesn't support it.
ilevkivskyi
approved these changes
Aug 17, 2018
mypy/fastparse.py
Outdated
| @overload | ||
| def visit(self, node: ast3.expr) -> Type: ... | ||
| @overload | ||
| def visit(self, node: ast3.expr) -> Type: ... |
ilevkivskyi
reviewed
Aug 17, 2018
mypy/fastparse.py
Outdated
| def visit(self, node: Optional[ast3.AST]) -> Any: | ||
| return self._visit_implementation(node) | ||
| def visit(self, node: Optional[ast3.AST]) -> Optional[Type]: # noqa | ||
| return self._visit_implementation(node) |
There was a problem hiding this comment.
Also I think _visit_implementation only existed because of conditional definition, you can kill it now.
ilevkivskyi
reviewed
Aug 17, 2018
mypy/fastparse.py
Outdated
| @@ -67,6 +67,13 @@ | |||
| TYPE_COMMENT_AST_ERROR = 'invalid type comment or annotation' | |||
|
|
|||
|
|
|||
| # Older versions of typing don't allow using overload outside stubs, | |||
| # so provide a dummy. | |||
| if sys.version_info < (3, 6): | |||
There was a problem hiding this comment.
Shouldn't this be guarded with a big if not MYPY:?
There was a problem hiding this comment.
mypy didn't seem to care, but probably ought to anyways
There was a problem hiding this comment.
On 3.4, the version of typing is newer than on 3.5, so you lose some type safety on 3.4. It works because you are only making the signature less exact, but it is more correct to use if MYPY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like they might not be necessary anymore, and mypyc doesn't
support it.