New semantic analyzer: Various small updates #6246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These respond to some review feedback to #6240.
ilevkivskyi
approved these changes
Jan 24, 2019
mypy/newsemanal/semanal_main.py
Outdated
| @@ -17,6 +17,9 @@ | |||
|
|
|||
| def semantic_analysis_for_scc(graph: 'Graph', scc: List[str]) -> None: | |||
| # Assume reachability analysis has already been performed. | |||
| # | |||
| # Note that functions can't define new module-level attributes, | |||
| # since module top levels are fully processed before functions. | |||
There was a problem hiding this comment.
Sorry for being annoying, but maybe explicitly mention global x here? (and clarify whether it is a temporary or principal limitation?)
| # flags: --new-semantic-analyzer | ||
| import b | ||
| [file a.py] | ||
| from b import bad # E: Module 'b' has no attribute 'bad' |
There was a problem hiding this comment.
I would prefer an error in both files, but at least one is also OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These respond to some review feedback to
#6240.