Skip to content

Give better error message (and don't crash) if bad json in the cache #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2019
Merged

Give better error message (and don't crash) if bad json in the cache #6277

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96cf22f
Give better error message (and don't crash) if bad json stored in the…
emmatyping Jan 31, 2019
814f815
Fix missing quote
emmatyping Jan 31, 2019
2f31db6
Use options.cache_dir
emmatyping Jan 31, 2019
02cc5e5
Fix file and remove space
emmatyping Feb 2, 2019
bc3b88d
Respond to review
emmatyping Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions mypy/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,8 +825,21 @@ def _load_json_file(file: str, manager: BuildManager,
manager.log(log_error + file)
return None
manager.trace(log_sucess + data.rstrip())
result = json.loads(data) # TODO: Errors
return result
try:
result = json.loads(data)
except ValueError: # TODO: JSONDecodeError in 3.5
manager.errors.set_file(file, None)
manager.errors.report(-1, -1,
"Error reading JSON file;"
" you likely have a bad cache.\n"
"Try removing the {cache_dir} directory"
" and run mypy again.".format(
cache_dir=manager.options.cache_dir
),
blocker=True)
return None
else:
return result


def _cache_dir_prefix(manager: BuildManager) -> str:
Expand Down