New semantic analyzer: Support multiple assignments to underscore #6450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis CI build is failing. |
|
I fixed the build, unfortunately with explicit |
JukkaL
reviewed
Feb 21, 2019
| @@ -2315,11 +2316,19 @@ def analyze_name_lvalue(self, | |||
| added = self.add_symbol(name, var, lvalue) | |||
| # Only bind expression if we successfully added name to symbol table. | |||
| if added: | |||
| lvalue.is_new_def = True | |||
| lvalue.is_inferred_def = True | |||
There was a problem hiding this comment.
Should this depend on explicit_type (presence of type annotation)?
There was a problem hiding this comment.
FWIW, I just copied the logic from make_name_lvalue_var(). My understanding is that process_type_annotation() which is called after analyze_lvalues() will set it to False (depending on annotation).
TBH, the logic is quite opaque here, and should be clean-up. I would however not do this because analyzers are merged, because it is very easy to break checker. I will create a follow-up issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also enable the existing test file with existing tests for this feature. I discovered a bug in
make_name_lvalue_var()that caused some existing tests to fail, so I fixed it.I skip three tests (they already have issues). I also updated one test case because the behavior is more consistent in new analyzer (it always shows
Cannot determine type, while old one shows this error only at global scope).