Support indexing unions containing tuples #6475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael0x2a
approved these changes
Feb 24, 2019
mypy/checkexpr.py
Outdated
| """ | ||
| index = e.index | ||
| if isinstance(left_type, UnionType): | ||
| return UnionType.make_simplified_union([self.visit_index_with_type(typ, e, left_type) |
There was a problem hiding this comment.
Just to check, should we pass original_type here as well?
There was a problem hiding this comment.
Normally, there should be no nested unions because they are flattened in the constructor, but I agree that it would be more robust to pass it also here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4286
Fixes #2509
The fix is straightforward, map the indexing through union types. I decided to use the existing error message mentioning the full type. IMO
Value of type "Union[int, List[int]]" is not indexableis better thanValue of type "int" is not idexable.