Ignore flake8 warnings about assert False

[msullivan]

No description provided.

[msullivan]

(Maybe we should pin a flake8 version?)

[gvanrossum]

What does flake8 want you to use???

[msullivan]

Do not call assert False since python -O removes these calls. Instead callers should raise AssertionError().

[gvanrossum]

(Maybe we should pin a flake8 version?)

Pinning deps seems to be a trend. :-) Though we should also strive to upgrade our dependencies regularly, which may become yet more busywork.

Also, the flake errors that this failed on look reasonable. Just poorly timed during our release cycle. :-)

[msullivan]

Also, the flake errors that this failed on look reasonable. Just poorly timed during our release cycle. :-)

Yeah. I am going to suppress them in config anyways, because of release cycle concerns, and then go back and actually fix them.

[msullivan]

(The new errors come from flake8-bugbear, it seems)

[msullivan]

Also, the flake errors that this failed on look reasonable. Just poorly timed during our release cycle. :-)

Yeah. I am going to suppress them in config anyways, because of release cycle concerns, and then go back and actually fix them.

Actually, in going to fix them, I've changed my mind. Basically every fix is adding either # type: ignore or # noqa. Might as well just keep it ignored.

[gvanrossum]

Actually, in going to fix them, I've changed my mind. Basically every fix is adding either # type: ignore or # noqa. Might as well just keep it ignored.

Hm, the ones about getattr(x, 'name') being in all ways inferior to x.name are correct, so those should be fixed using that substitution.