Skip to content

Fix stubgen mypyc type mismatch #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2019
Merged

Fix stubgen mypyc type mismatch #6642

merged 1 commit into from
Apr 6, 2019

Conversation

msullivan
Copy link
Collaborator

find_module_path_and_all_py3 promises to return __all__ as a List, but
__all__ could be a tuple or something. Make sure to convert it.

Fixes #6639.

@msullivan msullivan requested a review from ilevkivskyi April 6, 2019 18:20
find_module_path_and_all_py3 promises to return __all__ as a List, but
__all__ could be a tuple or something. Make sure to convert it.

Fixes #6639.
@msullivan msullivan force-pushed the fix-stubgen-crash branch from f45da48 to 4bde5d0 Compare April 6, 2019 18:21
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix!

@msullivan msullivan merged commit 486e4d7 into master Apr 6, 2019
@msullivan msullivan deleted the fix-stubgen-crash branch April 6, 2019 18:49
This was referenced Apr 11, 2019
msullivan added a commit that referenced this pull request Apr 15, 2019
find_module_path_and_all_py3 promises to return __all__ as a List, but
__all__ could be a tuple or something. Make sure to convert it.

Fixes #6639.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants