Skip to content

New semantic analyzer: enable tests related to recursively defined types #7080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Jun 27, 2019

There is a feature regression: we no longer expand recursive definition
once. I think that this is acceptable for now. We can either try to
replicate the expansion of recursive definitions later on, or we can
wait until we have full recursive support before we do anything about
this.

Only enabled tests that do something reasonable. Recursive type aliases
and other things still don't work.

Work towards #6445.

There is a feature regression: we no longer expand recursive definition
once. I think that this is acceptable for now. We can either try to
replicate the expansion of recursive definitions later on, or we can
wait until we have full recursive support before we do anything about
this.

Only enabled tests that do something reasonable. Recursive type aliases
and other things still don't work.

Work towards #6445.
@JukkaL JukkaL requested a review from ilevkivskyi June 27, 2019 13:57
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think there is no point in spending time on replicating the old behaviour. They just should not crash for now. Hopefully we will come back to this.

@JukkaL JukkaL merged commit 9438211 into master Jun 27, 2019
@JelleZijlstra JelleZijlstra deleted the semanal-recursive branch June 27, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants