New semantic analyzer: add test case for redefined nonlocal variable #7089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Jun 28, 2019
| def main(): | ||
| bar = [] # type: typing.List[int] | ||
|
|
||
| def foo(): |
There was a problem hiding this comment.
Is there any difference in behavior if these functions are annotated (i.e. checked)? Maybe we should have two tests (with and without annotations)?
|
|
||
| def foo(): | ||
| nonlocal bar | ||
| bar = [] # type: typing.List[int] |
There was a problem hiding this comment.
I think this should be an error, because this is essentially the same as:
bar: List[int]
bar: List[int] # Name 'bar' already definedMoreover:
>>> import typing
>>>
>>> def main():
... bar: typing.List[int] = []
... def g():
... nonlocal bar
... bar: typing.List[int] = []
File "<stdin>", line 5
SyntaxError: annotated name 'bar' can't be nonlocalThere was a problem hiding this comment.
It generates an error if the functions are annotated. Updated test case to also cover this.
ilevkivskyi
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7060.