modulefinder: use only dirs containing no __init__.py as namespace package #7108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage When used with --namespace-packages, a directory containing no __init__.pyi was previously added as a candidate to near_misses even if it contained a __init__.py. This logic doesn't seem sensible, particularly as this directory was then chosen as the result of find_module() instead of the __init__.py inside the directory. This should cure python#5854.
Those tests go hand in hand with the directory structure that was created in test-data/packages/modulefinder.
...and some more explaining comments.
awelzel
force-pushed
the
namespace-package-init
branch
from
3dd8ffd to
6a4cab9
Compare
Closed
gvanrossum
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with --namespace-packages, a directory containing no
__init__.pyiwas previously added as a candidate to near_misses even if it contained
a
__init__.py. This logic doesn't seem sensible, particularly as thisdirectory was then chosen as the result of find_module() instead of
the
__init__.pyinside the directory.This should cure #5854.