New semantic analyzer: fix bogus messages and update tests #7124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These recursive type definitions no longer cause crashes. Closes #6445.
ilevkivskyi
reviewed
Jul 2, 2019
test-data/unit/check-flags.test
Outdated
| VarsDict = Dict[str, Any] | ||
| HostsDict = Dict[str, Optional[VarsDict]] | ||
| VarsDict = Dict[str, Any] # type: ignore | ||
| HostsDict = Dict[str, Optional[VarsDict]] # type: ignore |
There was a problem hiding this comment.
Why these two ignores are needed? Both these aliases are not recursive and don't even have forward refs.
There was a problem hiding this comment.
Good catch! Yes, there is something suspicious going on.
JukkaL
changed the title
ilevkivskyi
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various recursive type definitions no longer cause crashes.
Fix bogus messages about cyclic definitions when definition is
acyclic when there are also recursive type definitions in the same
target.
Closes #6445.