Add new error code for unreachable statement #8312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael0x2a
reviewed
Jan 22, 2020
There was a problem hiding this comment.
Thanks for the PR!
I had a few suggestions, but this generally looks good.
Could you also make sure to add a section for this new error code in https://github.com/python/mypy/blob/master/docs/source/error_code_list2.rst? It doesn't need to be anything complicated -- just a short description and example would be great.
|
@Michael0x2a Sure! |
dhalenok
requested review from
Michael0x2a
and removed request for
ilevkivskyi
Michael0x2a
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8190.
This introduces a new error for
unreachable_statement.