Skip to content

dont process ignored modules #8729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

JulianSza
Copy link

dont touch ignored files

otherwise #3796 cannot be avoided by using ignore_modules in mypy.ini

work in progress, does not support * in module path

@JulianSza
Copy link
Author

Hmm... that was meant to hit my personal repo, not the official one... oh well:)

I was struggling with heavily nested dicts in our unit tests. Since we are just starting with mypy I was hoping I can just disable type checks for unit tests. Sadly ignore_errors in mypy.ini only prevents the errors from being printed, instead of being run (and therefore taking longer to execute)

Was there any reason for this choice? (this fix is working for us and its passing ./runtests but not sure if this impacts other use cases somehow

@JukkaL
Copy link
Collaborator

JukkaL commented Jun 8, 2020

If mypy is not behaving as expected, please file an issue first. (You can add a link to this PR in the issue.)

@hauntsaninja
Copy link
Collaborator

Closing as per Jukka's comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants