Skip to content

readme: separate out the "quick start" so it really is quick #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2015

Conversation

gnprice
Copy link
Collaborator

@gnprice gnprice commented Oct 7, 2015

No description provided.

@o11c
Copy link
Contributor

o11c commented Oct 7, 2015

Suggest that this wait until at least #721 is merged and probably #732 as well.

As far as I know, all important environments have python3, pip3, etc. so we should use that throughout. Also add comments about "yes, mypy runs on python3 even if you are checking python2 code", and once #732 is done remove the comment about python2 mode being unusable.

Also, since the packaged version is so old, we should probably use a git URL, such as what I put in my requirements.txt here, though likely we should include a @master for completeness.

@o11c
Copy link
Contributor

o11c commented Oct 8, 2015

Actually, should use python3 -m pip to be sure the version matches.

@refi64
Copy link
Contributor

refi64 commented Oct 8, 2015

@o11c IMO, if the person has multiple Python 3 versions installed, they already know how to invoke pip.

@o11c
Copy link
Contributor

o11c commented Oct 8, 2015

IME, it's not intuitive that pip3.2 install --upgrade pip (which pip spams you until you do) will result in changing pip and pip3 to be 3.2 instead of the newest version.

@refi64
Copy link
Contributor

refi64 commented Oct 8, 2015

IME

"In my experience"? Sorry, I'm bad at abbreviations... ;)

Also, I don't really get what you're saying...I mean, what does that have to do with running pip?

@o11c
Copy link
Contributor

o11c commented Oct 8, 2015

"In my experience"? Sorry, I'm bad at abbreviations... ;)

Yes.

Also, I don't really get what you're saying...I mean, what does that have to do with running pip?

It is quite likely that a user, in the course using pip, will unwittingly end up such that pip3 install mypy-lang followed by python3 <something that needs mypy or typing> will fail with ImportErrors (or worse, silently use the wrong module, leading to strange errors (or lack of expected errors) later on). Whereas python3 -m pip install mypy-lang will always work and DTRT.

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 9, 2015

Hmm maybe pip3 should be the default thing to recommend. Anybody care to check how things are on major platforms (OS X, Windows, Ubuntu 14.04 and newer) when using Python 3? On OS X we should probably consider both the official package from python.org and Homebew.

Here's one data point: On Ubuntu 14.04 pip is the Python 2 version. pip3 is available in the optional package python3-pip. Of course, when using virtualenv with Python 3.x pip will be the Python 3 version.

@o11c
Copy link
Contributor

o11c commented Oct 9, 2015

virtualenv always does pip -> pip3 -> pip3.X symlinks (or copies) though.

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 12, 2015

I've decided to recommend pip3 first. Still not 100% sure about this and we can iterate on this once we get more data.

@JukkaL JukkaL merged commit cdabada into python:master Oct 12, 2015
@gnprice gnprice deleted the readme branch December 10, 2015 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants