Skip to content

[mypyc] Various documentation updates #9098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 7, 2020
Merged

[mypyc] Various documentation updates #9098

merged 7 commits into from
Jul 7, 2020

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Jul 5, 2020

Includes many changes (this list is not exhaustive):

  • Document how to pass mypy options.
  • Document some additional primitives.
  • Protocols are now supported.
  • General wordsmithing.

@JukkaL JukkaL requested a review from msullivan July 5, 2020 16:54
Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor confusion.


Protocols can't be defined in compiled code. You can use protocols
defined elsewhere, however.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean protocols can be used now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, they should work now. Operations on them will fall back to generic operations, though.

@JukkaL JukkaL merged commit ffdbeb3 into master Jul 7, 2020
@JelleZijlstra JelleZijlstra deleted the mypyc-doc-updates branch July 7, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants