Fix Python 3.5 travis build by pinning pip #9949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When would you accept a PR that drops Python 3.5 support? |
| @@ -82,7 +82,7 @@ jobs: | |||
| # - EXTRA_ARGS= | |||
|
|
|||
| install: | |||
| - pip install -U pip setuptools | |||
| - pip install -U pip==20.3.4 setuptools | |||
There was a problem hiding this comment.
nit: could you add a comment that mentions Python 3.5 in some way so this is discoverable via grep
hauntsaninja
approved these changes
Jan 23, 2021
Around the time that Ubuntu 16.04 LTS goes out of support (this April), assuming that it's not too much of a pain to support Python 3.5 until then. |
JukkaL
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like pip just dropped Python 3.5 support, but we are not quite
yet ready to do it (as long as there's an easy workaround).
Example failure here:
https://travis-ci.com/github/python/mypy/jobs/474676438