Typos found by codespell #2073
Typos found by codespell #2073
Conversation
DimitriPapadopoulos
requested review from
1st1,
avassalotti,
birkenfeld,
brandtbucher,
brettcannon,
cjerdonek,
DinoV,
encukou,
ericsnowcurrently,
ethanfurman,
gvanrossum,
iritkatriel,
jeremyhylton,
larryhastings,
markshannon,
mitsuhiko,
ncoghlan,
pfmoore,
pitrou,
rhettinger,
ronaldoussoren,
stevendaprano,
tiran,
vstinner,
warsaw,
zooba and
a team
as code owners
pep-0659.rst
Outdated
| @@ -44,7 +44,7 @@ Both academic research and practical implementations have shown that a fast inte | |||
|
|
|||
| Typical optimizations for virtual machines are expensive, so a long "warm up" time is required | |||
| to gain confidence that the cost of optimization is justified. | |||
| In order to get speed-ups rapidly, without noticable warmup times, | |||
| In order to get speed-ups rapidly, without noticeable warm-up times, | |||
There was a problem hiding this comment.
True, but codespell prefers warm-up and so do Merriam-Webster and The Oxford Advanced Learner's Dictionary.
- 156,000,000 Google hits for warm-up
- 41,500,000 Google hits for warmup
There was a problem hiding this comment.
I'd prefer to leave the original author's wording unless it's clearly wrong. English spelling has some variation.
Similarly, you changed "reenable" to "re-enable" at some point. That can also stay as "reenable".
There was a problem hiding this comment.
OK, I'll keep it as it was.
As for re-enable, it's probably my wrong. I seem to recall it is a citation of a mail and shouldn't be changed. I'll look into it and fix it.
There was a problem hiding this comment.
That said, PEP 0659 itself is inconsistent:
"warm up" time
warmup times
brandtbucher
removed request for
vstinner,
warsaw,
tiran,
ronaldoussoren,
ncoghlan,
pfmoore,
rhettinger,
zooba,
pitrou,
stevendaprano and
brandtbucher
|
Honestly I don’t like such “omnibus” PRs. There’s often something that eluded review. And I don’t mind having the occasional typo, unless it makes the text hard to follow. The time to use a spell checker is when first writing the text. |
|
I understand, besides that's why I asked if such a PR acceptable. However, after fixing these typos, I could add a codespell GitHub action that could catch typos early on. I cannot add it as long as codespell reports too many errors. |
Co-authored-by: Jelle Zijlstra <[email protected]>
These typos detected by codespell are scattered over many PEPs. Should I really open a different PR for each PEP?