-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP 731: C API Working Group Charter #3476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Irit Katriel <[email protected]>
I intend to use the following process.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zooba!
Co-authored-by: Victor Stinner <[email protected]>
I see that's changed now, and I agree with the result! Let's put the bullet points in the guidelines PEP: capi-workgroup/api-evolution#26 |
Co-authored-by: Irit Katriel <[email protected]>
I think we're approaching convergence. Can all of you approve this version, or make specific suggestions? I'd like to tick boxes 1 and 2 above. |
And box 3, obviously (which follows logically from box 2). But first we need a better sentence for the first sentence of the Abstract. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Victor Stinner <[email protected]>
Please use PEP 731. ❯ pip install -U pepotron
...
❯ pep next
Next available PEP: 731 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I've added the checklist from https://github.com/python/peps/blob/main/.github/PULL_REQUEST_TEMPLATE/Add%20a%20new%20PEP.md to the top post, but not checked any off. One thing needed is a |
I understand that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels odd to see parts of PEP 729 immediately get reused here, but I'm happy that my proposal was helpful!
It felt like a useful template for this type of committee-forming PEP. We're probably going to borrow it for the Docs Editorial Board too. Thanks for coming up with it! We should probably add Contributed-By: Jelle to the final merge commit. |
PEP editors: The template @hugovk linked to claims that The only TODO I have for myself before this can be merged is @JelleZijlstra's comment on line 23. |
There's a bit of a catch-22: we can either merge the PEP without the fields, then post to discuss.python.org, and update the PEP file in another PR. Or post to discuss.python.org first, then update the file. |
So what's the best practice? It seems the tests pass without those header fields. |
I suggest: merge, post to discuss.python.org, then create a new PR. This is a bit nicer, you can post a proper link in the discussion. |
Agreed. Let's make them optional fields and permit new PEPs without them, and encourage that followup PR workflow. |
This is ready for review by the PEP editors and the general public. All co-authors have signed off on the current text (except for Victor's clarification of "other languages", which I took the liberty to merge).
Basic requirements (all PEP Types)
pep-NNNN.rst
), PR title (PEP 123: <Title of PEP>
) andPEP
headerAuthor
orSponsor
, and formally confirmed their approvalAuthor
,Status
(Draft
),Type
andCreated
headers filled out correctlyPEP-Delegate
,Topic
,Requires
andReplaces
headers completed if appropriate [none appropriate for this PEP].github/CODEOWNERS
for the PEP📚 Documentation preview 📚: https://pep-previews--3476.org.readthedocs.build/pep-0731/