Fix translation of html pages #263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
commented
Sep 9, 2025
| def setup(app: Sphinx) -> ExtensionMetadata: | ||
| app.require_sphinx("7.3") | ||
|
|
||
| app.add_html_theme("python_docs_theme", str(THEME_PATH)) | ||
| app.add_message_catalog(MESSAGE_CATALOG_NAME, LOCALE_DIR) | ||
|
|
||
| def add_translation_to_context(app, pagename, templatename, context, doctree): | ||
| _ = get_translation(MESSAGE_CATALOG_NAME) |
There was a problem hiding this comment.
So the issue here is, we are loading just messages from python-docs-theme.po for HTML files.
m-aciek
reviewed
Sep 9, 2025
Comment on lines
+25
to
+26
| if trans == msg: | ||
| return sphinx_gettext(msg) |
There was a problem hiding this comment.
Do we have strings that we don't extract, or rather it is used by languages that doesn't have theme translation and subset of strings is available in Sphinx translation?
There was a problem hiding this comment.
The strings for the index are in that file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There two issues, firstly some languages were not compiled and therefore don't load (e.g. Polish), and secondly, we hijacked the gettext for html files with
python-docs-theme.po, resulting in messages insphinx.ponot loading (e.g. Greek).Complete preview, built with translations: https://stan.ulbrych.org/preview/theme-translation/ (vs. current docs)
Compilation issue
We now get:
📚 Documentation preview 📚: https://python-docs-theme-previews--263.org.readthedocs.build/