Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

conversions.py2to3 doesn't work if there are unicode strings #66

Closed
msullivan opened this issue Jan 8, 2019 · 0 comments
Closed

conversions.py2to3 doesn't work if there are unicode strings #66

msullivan opened this issue Jan 8, 2019 · 0 comments

Comments

@msullivan
Copy link
Collaborator

The Str case doesn't pass the second kind field introduced by #49, so it will crash
msullivan added a commit that referenced this issue Jan 8, 2019
@msullivan
Fix conversions.py2to3 on unicode strings
1a21f77 
The introduction of string kinds in #49 missed updating the 2to3 visitor
for it. Update the `visit_Str` case to pass `s.kind` to `Str`.

Fixes #66.
@msullivan msullivan mentioned this issue Jan 8, 2019
Merged
msullivan added a commit that referenced this issue Jan 9, 2019
@msullivan
Fix conversions.py2to3 on unicode strings (#67)
40dcf10 
The introduction of string kinds in #49 missed updating the 2to3 visitor
for it. Update the `visit_Str` case to pass `s.kind` to `Str`.

Fixes #66.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msullivan