Skip to content

Upstream maintainer's permission and requests for packages #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srittau opened this issue Oct 31, 2018 · 2 comments
Closed

Upstream maintainer's permission and requests for packages #2573

srittau opened this issue Oct 31, 2018 · 2 comments
Labels
project: policy Organization of the typeshed project

Comments

@srittau
Copy link
Collaborator

srittau commented Oct 31, 2018

We currently require people that send patches for new third-party packages to get permission from upstream maintainers. What should we do if the upstream maintainers do not reply, like for example in #2384? I suggest that when there is no response for 14 days, we accept stubs as if upstream gave their permission.

On a related note: We have quite a few issues asking for third-party packages, but with no activity. I am not sure how useful it is to keep these issues around, unless there is some discussion or a link to an upstream maintainer's permission in the issue or someone is actively working on the stubs. With our current direction, we potentially want stubs for all pypi packages that don't ship their own, so I suggest we add a comment to the effect of "we accept contributions, ask upstream before starting" to such tickets and close them after 14 days if there is no more activity.

@srittau srittau added the project: policy Organization of the typeshed project label Oct 31, 2018
@JukkaL
Copy link
Contributor

JukkaL commented Oct 31, 2018

I'm in favor of the idea, but maybe 14 days is a bit too aggressive, since people are often on vacation for more than two weeks and may not be keeping up with email. I'd suggest waiting for 21 or 28 days.

If we had this rule, it could be easier to motivate somebody (such as me) to ask a significant number of widely used third-party packages for permission to add stubs to typeshed.

We could also add a file to typeshed with a list of third-party packages that have been approved for inclusion in typeshed (or where we got no response), and add a prominent link to the list somewhere.

close them after 14 days if there is no more activity.

I assume that this means closing the issue asking for permission in the upstream issue tracker (just asking for clarification).

@srittau
Copy link
Collaborator Author

srittau commented Oct 31, 2018

close them after 14 days if there is no more activity.

I meant closing issued tagged with type-stub-request if all they ask is "it would be great to have stubs for package foo", without any meaningful discussion after that. I think we should leave upstream requests for permission open indefinitely, even if we already added the stubs. (In that case we should leave a note in the upstream issue about that, though.) Let the upstream maintainers worry about closing it.

Edit: I am fine with a longer waiting time, say 21 days. But the longer we wait, the easier people are discouraged to contribute.

srittau added a commit to srittau/typeshed that referenced this issue Nov 19, 2018
Also, don't explicitly ask for people to ask for missing packages.

Closes python#2573
srittau added a commit that referenced this issue Nov 20, 2018
Also, don't explicitly ask for people to ask for missing packages.

Closes #2573
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this issue Jan 23, 2019
Also, don't explicitly ask for people to ask for missing packages.

Closes python#2573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: policy Organization of the typeshed project
Projects
None yet
Development

No branches or pull requests

2 participants