Skip to content

fix: use Self to ensure correct return type for EmailPolicy cloning #10301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2023

Conversation

hoefling
Copy link
Contributor

At the moment email.policy.EmailPolicy.clone() returns a Policy type, as can be reproduced with e.g.

$ mypy -c 'from email.policy import EmailPolicy; reveal_type(EmailPolicy().clone(utf8=True))'
<string>:1: note: Revealed type is "email.policy.Policy"
Success: no issues found in 1 source file

This differs at runtime:

$ python -c 'from email.policy import EmailPolicy; print(type(EmailPolicy().clone(utf8=True)))'
<class 'email.policy.EmailPolicy'>

This PR amends that.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit c88ce93 into python:main Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants