In email.feedparser, BytesFeedParser is a subclass of FeedParser #11110
Conversation
stdlib/email/feedparser.pyi
Outdated
| @overload | ||
| def __init__(self: BytesFeedParser[Message], _factory: None = None, *, policy: Policy = ...) -> None: ... | ||
| @overload | ||
| def __init__(self, _factory: Callable[[], _MessageT], *, policy: Policy = ...) -> None: ... | ||
| def feed(self, data: bytes | bytearray) -> None: ... | ||
| def feed(self, data: bytes | bytearray) -> None: ... # type: ignore[override] | ||
| def close(self) -> _MessageT: ... |
There was a problem hiding this comment.
I think we need to keep the redefinition of __init__ even though it's not actually redefined in the subclass in cpython, due to the typing on the self argument.
That said, the redefinition of close() here could be removed. it's identical to that of the superclass. I wasn't sure whether that meant that it should be removed or not. In the end it kept the diff very simple to leave it alone, so that's what I did.
There was a problem hiding this comment.
We generally remove redundant definitions in sub-classes, especially if they aren't defined in the implementation.
There was a problem hiding this comment.
Thanks - I removed it.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
related to #3968