Skip to content

Make attributes required on AST type_param classes #11202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2023
Merged

Make attributes required on AST type_param classes #11202

merged 1 commit into from
Dec 28, 2023

Conversation

jacobtylerwalls
Copy link
Contributor

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau requested a review from sobolevn December 28, 2023 12:00
sobolevn
sobolevn approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right. PR was backported to 3.12 as well.

Thank you!

@srittau srittau merged commit 07d1d2a into python:main Dec 28, 2023
@jacobtylerwalls jacobtylerwalls deleted the ast-type-param-required-attributes branch December 28, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobtylerwalls @sobolevn @srittau