Skip to content

Added some typings to peewee stubs #11284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

mikeziminio
Copy link
Contributor

No description provided.

This comment has been minimized.

@mikeziminio mikeziminio force-pushed the peewee-add-some-typings branch from 2b46e59 to 36d56b1 Compare January 17, 2024 11:38
@mikeziminio mikeziminio force-pushed the peewee-add-some-typings branch from 6441c79 to 40e5c70 Compare January 17, 2024 11:41
@mikeziminio mikeziminio force-pushed the peewee-add-some-typings branch from 33d34f3 to 31b719e Compare January 17, 2024 11:44
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member

Don't worry about the "run mypy on the test_cases" error. It's flaky at the moment and we're not sure why: #11220

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't compare this to the implementation, but the annotations all look reasonable.

@srittau srittau merged commit 11b842c into python:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants