Skip to content

regr_test.py: Run mypy with --no-incremental #11346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jan 30, 2024

Fixes #11220. Closes #11344; closes #11277. I'm currently stress-testing this locally to see if it does actually fix the intermittent crash. Creating a PR as well so that we can see if this significantly slows things down at all for us in CI. If it does, we'll be better off going with something like #11344, regardless of whether this fixes the crash.

@AlexWaygood
Copy link
Member Author

The good news is that this doesn't seem to slow things down much in CI, if at all. Still stress-testing locally to see whether it fixes the crash...

@AlexWaygood AlexWaygood marked this pull request as ready for review January 30, 2024 13:48
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Jan 30, 2024

I let my repro script from #11220 (comment) run for over two hours with this PR branch (which on my slow laptop was enough for 26 iterations). There were no crashes. Prior to #11343, like @hauntsaninja reported in #11343 (comment), I was seeing frequent crashes involving resource.struct_rusage, and less frequent crashes involving other classes. I would always have seen a crash before 26 iterations.

If somebody else wants to do more stress-testing, feel free, but I need to reclaim my laptop for other tasks now, since stress-testing this PR uses all of my laptop's cores 😄

@JelleZijlstra
Copy link
Member

Incremental mode probably doesn't help in CI anyway since there won't be any cache.

@JelleZijlstra JelleZijlstra merged commit c50a641 into python:main Jan 30, 2024
@AlexWaygood AlexWaygood deleted the fix-regr-test-crash2 branch January 30, 2024 17:02
@AlexWaygood
Copy link
Member Author

Incremental mode probably doesn't help in CI anyway since there won't be any cache.

Yeah, and performance doesn't matter nearly as much for local usage, since I doubt anybody's running the script with --all locally (I certainly am not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky mypy error on typeshed test_cases
3 participants