Remove all mention of 'module' from typeshed. #1156
Conversation
This depends on python/mypy#3107.
|
Looks fine to me. One less keyword special to typeshed to worry about. |
| @@ -26,6 +26,7 @@ if sys.version_info >= (3, 4): | |||
| class ModuleType: | |||
There was a problem hiding this comment.
__doc__ = ... # type: Optional[str]
There was a problem hiding this comment.
Shouldn't be needed, since __doc__ is defined on object, which is implicitly inherited.
|
LGTM |
|
D'oh, this seems a duplicate of #1127. But maybe we should make sure one isn't better than the other? There seem to be small differences. |
|
Even the test failures (a bunch of internal errors in mypy) are similar. |
|
Oh I think we should close mine in favor of yours; the only extra stuff I have is in |
| @@ -102,15 +103,15 @@ chain = ... # type: type | |||
| double3prog = ... # type: type | |||
| endprogs = ... # type: Dict[str, Any] | |||
| pseudoprog = ... # type: type | |||
| re = ... # type: module | |||
There was a problem hiding this comment.
Can remove re = ... entirely.
There was a problem hiding this comment.
Honestly a lot here should probably be removed -- it's only there because that's how pytype generates stubs (every imported thing ends up in the stub, even if it's clearly for purely internal reasons, and it never generates import statements). But I think that's a cleanup for a separate PR.
|
Once python/mypy#3107 is merged let's trigger tests here and then hopefully it will work. |
Mostly to re-trigger tests
|
Thanks! |
Specifically to include python/typeshed#1156 which is important follow-up for #3107.
Also add
__dict__to the existingtypes.ModuleTypeclasses.This depends on python/mypy#3107, and the tests may fail without that; also mypy's tests (even with that) won't fail with this. But I'd like to create this PR so @pkch can take a look. Also @matthiaskramm please note this, hopefully this won't break any pytype stuff (either in typeshed or at Google).