-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Make email.message.Message generic over the header type #11732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The email/http |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small adjustment for a comment mentioning the Any trick, otherwise this looks good to me.
Co-authored-by: Avasam <[email protected]>
Diff from mypy_primer, showing the effect of this PR on open source code: spack (https://github.com/spack/spack)
- lib/spack/spack/oci/oci.py:142: error: Argument 1 to "endpoint" of "ImageReference" has incompatible type "str | None"; expected "str" [arg-type]
|
This seems to have introduced a regression for me at least on Python 3.10, not sure if it works better on say 3.12... This results in an error:
Not clear how this should be typed anymore. If I try to do I'll set to ignore for now but just as a heads-up. |
No description provided.