Update configparser.SectionProxy.get* to return T | None when fallback is not specified
#12936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: nox (https://github.com/wntrblm/nox)
+ nox/tox_to_nox.py:128: error: Argument 1 to "Path" has incompatible type "Optional[str]"; expected "Union[str, PathLike[str]]" [arg-type]
|
The-Compiler
added a commit
to qutebrowser/qutebrowser
that referenced
this pull request
Jan 6, 2025
mypy does not do type narrowing with "in": python/mypy#12535 And mypy now knows that those values can be None: python/typeshed#12936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12933
All
SectionProxy.get*methods returnNonewhen the key isn't found and afallbackisn't specified.Since
Nonebeing returned is both likely and semantically meaningful, I think returning a union and forcing callers to handle theNonecase makes sense here.