Clear up tool.ruff.lint.isort.extra-standard-library
#13070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
changed the title
tool.ruff.lint.isort.extra-standard-library
srittau
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mostly leftover from when we were using isort. I think that if any stdlib module isn't recognized by Ruff still, it should simply be added there.
CC @AlexWaygood in case I'm wrong in assuming Ruff should recognize all private stdlib modules and the lack of new detection is just a coincidence.
Kept
zoneinfosince we still match Python 3.8. Even though our currentzoneinfoimports are always alone so atm it wouldn't even trigger a violation.