Fix incorrect default value for callback #13678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream uses a default value of False when popping "callback" off of the kwargs dict. The type stubs should show callback as defaulting to False. See: https://github.com/miguelgrinberg/Flask-SocketIO/blob/3dbc92facf99d6bf1e7e354890c6113657c6f8e6/src/flask_socketio/test_client.py#L179
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream uses a default value of False when popping
callbackoff of the kwargs dict. The type stubs should showcallbackas defaulting to False instead of True.See: https://github.com/miguelgrinberg/Flask-SocketIO/blob/3dbc92facf99d6bf1e7e354890c6113657c6f8e6/src/flask_socketio/test_client.py#L179