fix DictReader definition #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* constructable with Iterable * __iter__ returns another DictReader * supports `__next__` on python 3 * supports `next` on python 2
|
and I've updated the documentation on cpython accordingly: python/cpython#2653 |
graingert
commented
Jul 11, 2017
| if sys.version_info >= (3,): | ||
| def __next__(self) -> OrderedDict[Any, str]: ... | ||
| else: | ||
| def next(self) -> OrderedDict[Any, str]: ... |
There was a problem hiding this comment.
Wondering if these should be regular dicts on python < 3.6
|
Does this need to be included in 0.521? If so we need to do a typeshed sync
in mypy.
|
|
I think so, there was a regression since 0.511 (DictReader could not be instantiated). |
25 tasks
gvanrossum
pushed a commit
that referenced
this pull request
Jul 18, 2017
* constructable with Iterable * __iter__ returns another DictReader * supports `__next__` on python 3 * supports `next` on python 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__next__on python 3nexton python 2