csv DictReader should only yield OrderedDicts in Py3.6 #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
although of course this is still wrong out of the box DictReader supports returning floats and strings |
graingert
force-pushed
the
csv-dict-reader-od-only-in-3-6
branch
2 times, most recently
from
3df0b5c to
fe221f8
Compare
JelleZijlstra
requested changes
Jul 11, 2017
stdlib/2and3/csv.pyi
Outdated
| restkey: Optional[str] = ..., restval: Optional[str] = ..., dialect: _Dialect = ..., | ||
| *args: Any, **kwds: Any) -> None: ... | ||
| def __iter__(self) -> 'DictReader': ... | ||
| def __next__(self) -> _DRMapping: ... |
There was a problem hiding this comment.
This is redundant, you have __next__ below.
graingert
force-pushed
the
csv-dict-reader-od-only-in-3-6
branch
from
fe221f8 to
e98474b
Compare
|
@JelleZijlstra ok, done |
JelleZijlstra
approved these changes
Jul 15, 2017
gvanrossum
pushed a commit
that referenced
this pull request
Jul 24, 2017
gvanrossum
pushed a commit
to gvanrossum/mypy
that referenced
this pull request
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.