-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
a sprinkle of unicode #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
def warning(self, msg: Union[str, unicode], *args, **kwargs) -> None: ... | ||
def warn(self, msg: Union[str, unicode], *args, **kwargs) -> None: ... | ||
def error(self, msg: Union[str, unicode], *args, **kwargs) -> None: ... | ||
def exception(self, msg: Unions[str, unicode], *args, **kwargs) -> None: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo (Unions).
Actually this would probably work just as well with just |
@gvanrossum Fixed, now just |
I'd prefer if we did not make the assumption that all type-checkers consider I know mypy is one of the primary users of typeshed, but implementation details of mypy still shouldn't leak into typeshed. |
Really sorry, I had forgotten about that. Let's go back to the Unions, at least until we have agreement on what to do for strings (python/mypy#1141 -- though we should really have the discussion in https://github.com/python/typing/issues). |
Added python/typing#204, in an attempt to merge the two discussion threads. Yes, let's use Unions for the time being. Maybe it would make sense to have a "Text" type in typeshed only. |
Thank you all; this is ready for merging. |
Thanks! |
Don't iterate over ellipsis in Callable when evaluating types. Fix python#149
No description provided.