Make exceptions.pyi import its definitions from __builtin__.pyi #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,80 +1,49 @@ | |||
| from typing import Any, Tuple, Optional | |||
| from __builtin__ import ArithmeticError | |||
There was a problem hiding this comment.
This needs to be ArithmeticError as ArithmeticError so that the name is re-exported from this module.
There was a problem hiding this comment.
Ah, that's the test failure was about. I'll send another pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were previously two copies of the exception classes, one in exceptions.pyi and one in builtin.pyi.