minor namedtuple fixes #2227
Merged
minor namedtuple fixes #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would recommend to not hope on this, named tuples are so deeply special-cased. I would rather recommend updating |
|
Ah, I see you already did this :-) |
|
Yes, it actually wasn't that hard. |
|
This has been open for a while and is fairly simple; could someone review it? (@ilevkivskyi maybe?) |
ilevkivskyi
approved these changes
Aug 19, 2018
|
Thanks! |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
- The extra arguments aren't keyword-only in 2.7. - Added the `defaults` argument in 3.7 (https://docs.python.org/3.7/library/collections.html#collections.namedtuple).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultsargument in 3.7 (https://docs.python.org/3.7/library/collections.html#collections.namedtuple).I'm hoping I'll be able to convince mypy to use these stubs to check calls to
namedtuple(); see python/mypy#2127 and python/mypy#4788. Regardless, we should fix the namedtuple stubs in case other type checkers may be using them.