Improve annotations for json.load() and loads() #2382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
srittau
commented
Aug 14, 2018
srittau
commented
- loads() only accepts str as first argument for Python < 3.6
- Use a protocol for the first argument to load() (cf Add typing.Reader and typing.Writer typing#564)
* loads() only accepts str as first argument for Python < 3.6 * Use a protocol for the first argument to load() (cf python/typing#564)
JelleZijlstra
approved these changes
Aug 14, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
* loads() only accepts str as first argument for Python < 3.6 * Use a protocol for the first argument to load() (cf python/typing#564)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.